jingrow/gunicorn
1
0
Fork 0
mirror of https://github.com/frappe/gunicorn.git synced 2026-01-14 11:09:11 +08:00
Code Issues Packages Projects Releases Wiki Activity

Don't call logging functions in the signal handler.

Browse Source 
The standard logger uses locking functions which are NOT guaranteed to
be re-entrant [1], so this could (potentially) result in deadlock or a
crash.

[1] http://docs.python.org/library/logging.html Section 15.7.8.
This commit is contained in:
Evan Mezeske 2011-10-24 17:35:46 -07:00 committed by benoitc
parent b5622f874b
commit 3c1f1cb126
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
gunicorn/arbiter.py
View File

@ -147,8 +147,6 @@ class Arbiter(object):
if len(self.SIG_QUEUE) < 5: if len(self.SIG_QUEUE) < 5:
self.SIG_QUEUE.append(sig) self.SIG_QUEUE.append(sig)
self.wakeup() self.wakeup()
else:
self.log.warning("Dropping signal: %s", sig)
def run(self): def run(self):
"Main master loop." "Main master loop."