fix: resolve lint issues in dirty arbiter modules

This commit is contained in:
Benoit Chesneau 2026-01-24 02:37:43 +01:00
parent 77222b8017
commit 21f769ce16
7 changed files with 5 additions and 16 deletions

View File

@ -16,7 +16,6 @@ import signal
import sys
import tempfile
import time
import traceback
from gunicorn import util
@ -357,7 +356,7 @@ class DirtyArbiter:
sys.exit(0)
except SystemExit:
raise
except Exception as e:
except Exception:
self.log.exception("Exception in dirty worker process")
if not worker.booted:
sys.exit(self.WORKER_BOOT_ERROR)

View File

@ -125,7 +125,7 @@ class DirtyClient:
except socket.timeout:
self._close_socket()
raise DirtyTimeoutError(
f"Timeout waiting for dirty app response",
"Timeout waiting for dirty app response",
timeout=self.timeout
)
except Exception as e:
@ -238,7 +238,7 @@ class DirtyClient:
except asyncio.TimeoutError:
await self._close_async()
raise DirtyTimeoutError(
f"Timeout waiting for dirty app response",
"Timeout waiting for dirty app response",
timeout=self.timeout
)
except Exception as e:

View File

@ -12,7 +12,6 @@ from the DirtyArbiter.
import asyncio
import os
import signal
import sys
import traceback
import uuid
@ -214,7 +213,6 @@ class DirtyWorker:
Each connection can send multiple requests.
"""
addr = writer.get_extra_info('peername')
self.log.debug("New connection from arbiter")
try:

View File

@ -4,7 +4,6 @@
"""Tests for dirty client module."""
import asyncio
import os
import socket
import tempfile
@ -17,7 +16,6 @@ from gunicorn.dirty.client import (
get_dirty_socket_path,
set_dirty_socket_path,
close_dirty_client,
_thread_local,
)
from gunicorn.dirty.errors import DirtyConnectionError, DirtyError
from gunicorn.dirty.protocol import DirtyProtocol, make_response

View File

@ -155,7 +155,6 @@ class TestDirtyExecutionTimeout:
import tempfile
from gunicorn.dirty.arbiter import DirtyArbiter
from gunicorn.dirty.protocol import DirtyProtocol, make_request
from gunicorn.dirty.errors import DirtyTimeoutError
class MockLog:
def debug(self, *a, **kw): pass

View File

@ -5,6 +5,7 @@
"""Tests for dirty arbiter protocol module."""
import asyncio
import os
import socket
import struct
import pytest
@ -183,7 +184,7 @@ class TestDirtyProtocolAsync:
read_fd, write_fd = os.pipe()
try:
reader = asyncio.StreamReader()
protocol = asyncio.StreamReaderProtocol(reader)
_ = asyncio.StreamReaderProtocol(reader)
# Write the message to the pipe
encoded = DirtyProtocol.encode(message)
@ -369,7 +370,3 @@ class TestDirtyErrors:
assert error.action == "run"
assert error.traceback == "Traceback..."
assert "myapp:App" in str(error)
# Add import needed for async tests
import os

View File

@ -662,8 +662,6 @@ class TestDirtyWorkerRunAsync:
reader.feed_data(encoded_request)
reader.feed_eof()
responses = []
class MockWriter:
def __init__(self):
self.closed = False