jingrow/gunicorn
1
0
Fork 0
mirror of https://github.com/frappe/gunicorn.git synced 2026-01-14 11:09:11 +08:00
Code Issues Packages Projects Releases Wiki Activity

Close connection on error after sending started.

Browse Source 
When the application starts yielding a body and then raises an error,
we should immediately close the connection to the client to indicate
the error.
This commit is contained in:
Alexandre Zani 2013-02-28 23:43:23 -08:00 committed by benoitc
parent 230b2ba4ef
commit 12ec996d54
2 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
gunicorn/workers/async.py
View File

@ -104,6 +104,13 @@ class AsyncWorker(base.Worker):
respiter.close() respiter.close()
if resp.should_close(): if resp.should_close():
raise StopIteration() raise StopIteration()
except Exception:
if resp.headers_sent:
# If the requests have already been sent, we should close the
# connection to indicate the error.
sock.shutdown(socket.SHUT_RDWR)
sock.close()
raise
finally: finally:
try: try:
self.cfg.post_request(self, req, environ, resp) self.cfg.post_request(self, req, environ, resp)

5
gunicorn/workers/sync.py
View File

@ -138,6 +138,11 @@ class SyncWorker(base.Worker):
except socket.error: except socket.error:
raise raise
except Exception as e: except Exception as e:
if resp.headers_sent:
# If the requests have already been sent, we should close the
# connection to indicate the error.
client.shutdown(socket.SHUT_RDWR)
client.close()
# Only send back traceback in HTTP in debug mode. # Only send back traceback in HTTP in debug mode.
self.handle_error(req, client, addr, e) self.handle_error(req, client, addr, e)
return return