From 10a41a1cc5dd3b242dc61744fce22277c422d839 Mon Sep 17 00:00:00 2001 From: Tanmoy Sarkar Date: Sat, 13 Jun 2026 00:00:07 +0530 Subject: [PATCH] fix(ci): Avoid pylint pointless-statement in signal validation The bare signal.Signals[...] lookup used only for its side effect tripped pylint W0104. Replace the try/except with an explicit membership test against signal.Signals, which validates both signal names and numbers without a pointless expression. Co-Authored-By: Claude Opus 4.8 (1M context) --- gunicorn/companion/config.py | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/gunicorn/companion/config.py b/gunicorn/companion/config.py index 9382919e..b14bb18e 100644 --- a/gunicorn/companion/config.py +++ b/gunicorn/companion/config.py @@ -101,12 +101,11 @@ def _validate_stop_signal(stop_signal, name): config is loaded or rereaded, rather than crashing the manager later when it tries to send the signal. """ - try: - if isinstance(stop_signal, str): - signal.Signals[stop_signal] - else: - signal.Signals(stop_signal) - except (KeyError, ValueError): + if isinstance(stop_signal, str): + valid = stop_signal in signal.Signals.__members__ + else: + valid = stop_signal in set(signal.Signals) + if not valid: raise ValueError( "companion %s has unknown stop_signal %r" % (name, stop_signal))