jingrow/gunicorn
1
0
Fork 0
mirror of https://github.com/frappe/gunicorn.git synced 2026-07-02 18:51:31 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: warn once when ASGI app emits a body for a no-body response

Browse Source 
A framework bug — say, returning bytes from a HEAD or 204 handler — is
now logged at WARNING level the first time it happens for a request
so the misbehavior is visible without spamming on multi-chunk streams.
This commit is contained in:
Benoit Chesneau 2026-05-03 20:25:23 +02:00
parent 2191832b8d
commit 0d35d2ae44
1 changed files with 13 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
gunicorn/asgi/protocol.py
View File

@ -906,6 +906,7 @@ class ASGIProtocol(asyncio.Protocol):
exc_to_raise = None exc_to_raise = None
use_chunked = False use_chunked = False
omits_body = False omits_body = False
omits_body_warned = False
# Reset response buffer for write batching # Reset response buffer for write batching
self._response_buffer = None self._response_buffer = None
@ -921,6 +922,7 @@ class ASGIProtocol(asyncio.Protocol):
async def send(message): async def send(message):
nonlocal response_started, response_complete, exc_to_raise nonlocal response_started, response_complete, exc_to_raise
nonlocal response_status, response_headers, response_sent, use_chunked, omits_body nonlocal response_status, response_headers, response_sent, use_chunked, omits_body
nonlocal omits_body_warned
# If client disconnected, silently ignore send attempts # If client disconnected, silently ignore send attempts
# This allows apps to finish cleanup without errors # This allows apps to finish cleanup without errors
@ -994,10 +996,19 @@ class ASGIProtocol(asyncio.Protocol):
more_body = message.get("more_body", False) more_body = message.get("more_body", False)
# RFC 9110: HEAD/1xx/204/304 responses must not carry a body, # RFC 9110: HEAD/1xx/204/304 responses must not carry a body,
# even if the framework emits one. Drop body bytes silently; # even if the framework emits one. Drop body bytes;
# use_chunked has already been forced False above so no # use_chunked has already been forced False above so no
# terminator will be written either. # terminator will be written either. Warn once per request
# so framework bugs surface in logs without spamming on
# multi-chunk streams.
if omits_body: if omits_body:
if body and not omits_body_warned:
self.log.warning(
"ASGI app sent body bytes on a no-body response "
"(method=%s status=%s); dropping per RFC 9110.",
request.method, response_status,
)
omits_body_warned = True
body = b"" body = b""
if body: if body: