jingrow/gantt
1
0
Fork 0
Code Pull Requests Activity

Element parameter support for HTML Element, SVG Element or CSS selector (#25)

Browse Source 
* * adjusted the library to support both string css selectors and a raw svg element when resetting its internal variables

* * changes parent_element to use const again instead of let

* * updated the element selection logic to include checking for an html element and finding a child svg object

* * updated parameter comment and exception message to mention both html and svg dom element support

* Code formatting
This commit is contained in:
Faris Ansari 2017-07-31 14:46:10 +05:30 committed by GitHub
parent 78033cd689
commit 241c65db69
1 changed files with 13 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/Gantt.js
View File

@ -1,7 +1,7 @@
/* global moment, Snap */
/**
* Gantt:
* element: querySelector string, required
* element: querySelector string, HTML DOM or SVG DOM element, required
* tasks: array of tasks, required
* task: { id, name, start, end, progress, dependencies, custom_class }
* config: configuration options, optional
@ -60,8 +60,17 @@ export default function Gantt(element, tasks, config) {
}
function reset_variables(tasks) {
if(typeof element === 'string') {
self.element = document.querySelector(element);
} else if (element instanceof SVGElement) {
self.element = element;
} else if (element instanceof HTMLElement) {
self.element = element.querySelector('svg');
} else {
throw new TypeError('Frappé Gantt only supports usage of a string CSS selector,' +
' HTML DOM element or SVG DOM element for the \'element\' parameter');
}
self.element = element;
self._tasks = tasks;
self._bars = [];
@ -260,7 +269,8 @@ export default function Gantt(element, tasks, config) {
}
function set_scroll_position() {
const parent_element = document.querySelector(self.element).parentElement;
const parent_element = self.element.parentElement;
if(!parent_element) return;
const scroll_pos = get_min_date().diff(self.gantt_start, 'hours') /