jingrow/datatable
1
0
Fork 0
Code Pull Requests Activity

fix: 🐛 Numeric comparison should compare with cell value

Browse Source 
Numeric comparison like >, < should compare with the cell value and not
the formatted html value
This commit is contained in:
Faris Ansari 2018-11-29 13:41:07 +05:30
parent ec08d75261
commit f791c91df6
2 changed files with 66 additions and 50 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

110
index.html
View File

File diff suppressed because one or more lines are too long

6
src/filterRows.js
View File

@ -40,7 +40,7 @@ function getFilterMethod(filter) {
greaterThan(keyword, cells) { greaterThan(keyword, cells) {
return cells return cells
.filter(cell => { .filter(cell => {
const value = Number(stripHTML(cell.html)); const value = parseFloat(cell.content);
return value > keyword; return value > keyword;
}) })
.map(cell => cell.rowIndex); .map(cell => cell.rowIndex);
@ -49,7 +49,7 @@ function getFilterMethod(filter) {
lessThan(keyword, cells) { lessThan(keyword, cells) {
return cells return cells
.filter(cell => { .filter(cell => {
const value = Number(stripHTML(cell.html)); const value = parseFloat(cell.content);
return value < keyword; return value < keyword;
}) })
.map(cell => cell.rowIndex); .map(cell => cell.rowIndex);
@ -58,7 +58,7 @@ function getFilterMethod(filter) {
range(rangeValues, cells) { range(rangeValues, cells) {
return cells return cells
.filter(cell => { .filter(cell => {
const value = Number(stripHTML(cell.html)); const value = parseFloat(cell.content);
return value >= rangeValues[0] && value <= rangeValues[1]; return value >= rangeValues[0] && value <= rangeValues[1];
}) })
.map(cell => cell.rowIndex); .map(cell => cell.rowIndex);