From 3712aaada3bc9b4dfa1111df5aa335d2c929607a Mon Sep 17 00:00:00 2001 From: Deepesh Garg <42651287+deepeshgarg007@users.noreply.github.com> Date: Fri, 5 Jul 2019 13:14:55 +0530 Subject: [PATCH] fix: Navigation fix using tabs in inline filters (#75) --- src/cellmanager.js | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/src/cellmanager.js b/src/cellmanager.js index 739c16c..b41dcfa 100644 --- a/src/cellmanager.js +++ b/src/cellmanager.js @@ -54,13 +54,6 @@ export default class CellManager { this.deactivateEditing(); } }); - this.keyboard.on('tab, shift+tab', (e) => { - if (this.$editingCell) { - // tab keypress on editing cell - this.deactivateEditing(); - this.focusCellInDirection(e.shiftKey ? 'left' : 'right'); - } - }); } bindKeyboardNav() { @@ -647,8 +640,10 @@ export default class CellManager { } focusCellInDirection(direction) { - if (!this.$focusedCell || this.$editingCell) { + if (!this.$focusedCell) { return false; + } else if (this.$editingCell && ['tab', 'shift+tab'].includes(direction)) { + this.deactivateEditing(); } let $cell = this.$focusedCell;