From 1a0eba65a0ddb59f5d5fc754d47cad2a9be0a42f Mon Sep 17 00:00:00 2001 From: Faris Ansari Date: Mon, 24 Jun 2019 15:08:39 +0530 Subject: [PATCH] fix: Number compare - 006 will match abc006 - 1230 will match 1,230 (formatted), 1230 and abc1230 --- src/filterRows.js | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/filterRows.js b/src/filterRows.js index f4849ce..9e9fd78 100644 --- a/src/filterRows.js +++ b/src/filterRows.js @@ -111,12 +111,12 @@ function getFilterMethod(filter) { containsNumber(keyword, cells) { return cells .filter(cell => { - let hay = numberCompareValue(cell); - if (isNaN(hay)) { - hay = stringCompareValue(cell); - } - const needle = keyword; - return !needle || hay.toString().includes(needle); + let number = parseFloat(keyword, 10); + let string = keyword; + let hayNumber = numberCompareValue(cell); + let hayString = stringCompareValue(cell); + + return number === hayNumber || hayString.includes(string); }) .map(cell => cell.rowIndex); } @@ -166,7 +166,7 @@ function guessFilter(keyword = '') { if (isNumber(compareString)) { return { type: 'containsNumber', - text: parseFloat(keyword, 10) + text: compareString }; }