jingrow/datatable
1
0
Fork 0
Code Pull Requests Activity

fix: Scroll problem when cell is focused

Browse Source
This commit is contained in:
Faris Ansari 2019-03-30 17:19:23 +05:30
parent 0f44a51da3
commit 1845adc46e
1 changed files with 16 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
src/cellmanager.js
View File

@ -212,7 +212,9 @@ export default class CellManager {
} }
focusCell($cell, { focusCell($cell, {
skipClearSelection = 0 skipClearSelection = 0,
skipDOMFocus = 0,
skipScrollToCell = 0
} = {}) { } = {}) {
if (!$cell) return; if (!$cell) return;
@ -232,7 +234,9 @@ export default class CellManager {
return; return;
} }
this.scrollToCell($cell); if (!skipScrollToCell) {
this.scrollToCell($cell);
}
this.deactivateEditing(); this.deactivateEditing();
if (!skipClearSelection) { if (!skipClearSelection) {
@ -246,8 +250,10 @@ export default class CellManager {
this.$focusedCell = $cell; this.$focusedCell = $cell;
$cell.classList.add('dt-cell--focus'); $cell.classList.add('dt-cell--focus');
// so that keyboard nav works if (!skipDOMFocus) {
$cell.focus(); // so that keyboard nav works
$cell.focus();
}
this.highlightRowColumnHeader($cell); this.highlightRowColumnHeader($cell);
} }
@ -313,11 +319,15 @@ export default class CellManager {
const $cell = this.getCell$(colIndex, rowIndex); const $cell = this.getCell$(colIndex, rowIndex);
if (!$cell) return; if (!$cell) return;
// this function is called after selectAreaOnClusterChanged, // this function is called after hyperlist renders the rows after scroll,
// focusCell calls clearSelection which resets the area selection // focusCell calls clearSelection which resets the area selection
// so a flag to skip it // so a flag to skip it
// we also skip DOM focus and scroll to cell
// because it fights with the user scroll
this.focusCell($cell, { this.focusCell($cell, {
skipClearSelection: 1 skipClearSelection: 1,
skipDOMFocus: 1,
skipScrollToCell: 1
}); });
} }