jingrow/charts
1
0
Fork 0
Code Pull Requests Activity

Fix: Sometimes index === -1

Browse Source 
Sometimes when mouse-overing container, i got `vendors.app.js:8427 Uncaught TypeError: Cannot read property 'xPos' of undefined` that is caused by `-1` index
This commit is contained in:
Emīls Gulbis 2019-10-07 14:45:16 +03:00 committed by GitHub
parent 39211a406d
commit f85daa3d6e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 11 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
src/js/charts/AxisChart.js
View File

@ -405,17 +405,19 @@ export default class AxisChart extends BaseChart {
if(!s.yExtremes) return; if(!s.yExtremes) return;
let index = getClosestInArray(relX, s.xAxis.positions, true); let index = getClosestInArray(relX, s.xAxis.positions, true);
let dbi = this.dataByIndex[index]; if (index >= 0) {
let dbi = this.dataByIndex[index];
this.tip.setValues( this.tip.setValues(
dbi.xPos + this.tip.offset.x, dbi.xPos + this.tip.offset.x,
dbi.yExtreme + this.tip.offset.y, dbi.yExtreme + this.tip.offset.y,
{name: dbi.formattedLabel, value: ''}, {name: dbi.formattedLabel, value: ''},
dbi.values, dbi.values,
index index
); );
this.tip.showTip(); this.tip.showTip();
}
} }
renderLegend() { renderLegend() {