chore: formatting changes

This commit is contained in:
Arjun Choudhary 2022-11-15 17:33:19 +05:30
parent a839277732
commit ddbd30ca07

View File

@ -1,30 +1,47 @@
import SvgTip from '../objects/SvgTip';
import { $, isElementInViewport, getElementContentWidth, isHidden } from '../utils/dom';
import { makeSVGContainer, makeSVGDefs, makeSVGGroup, makeText } from '../utils/draw';
import { BASE_MEASURES, getExtraHeight, getExtraWidth, getTopOffset, getLeftOffset,
INIT_CHART_UPDATE_TIMEOUT, CHART_POST_ANIMATE_TIMEOUT, DEFAULT_COLORS} from '../utils/constants';
import { getColor, isValidColor } from '../utils/colors';
import { runSMILAnimation } from '../utils/animation';
import { downloadFile, prepareForExport } from '../utils/export';
import { deepClone } from '../utils/helpers';
import SvgTip from "../objects/SvgTip";
import {
$,
isElementInViewport,
getElementContentWidth,
isHidden,
} from "../utils/dom";
import {
makeSVGContainer,
makeSVGDefs,
makeSVGGroup,
makeText,
} from "../utils/draw";
import {
BASE_MEASURES,
getExtraHeight,
getExtraWidth,
getTopOffset,
getLeftOffset,
INIT_CHART_UPDATE_TIMEOUT,
CHART_POST_ANIMATE_TIMEOUT,
DEFAULT_COLORS,
} from "../utils/constants";
import { getColor, isValidColor } from "../utils/colors";
import { runSMILAnimation } from "../utils/animation";
import { downloadFile, prepareForExport } from "../utils/export";
import { deepClone } from "../utils/helpers";
export default class BaseChart {
constructor(parent, options) {
// deepclone options to avoid making changes to orignal object
options = deepClone(options);
this.parent = typeof parent === 'string'
? document.querySelector(parent)
: parent;
this.parent =
typeof parent === "string" ? document.querySelector(parent) : parent;
if (!(this.parent instanceof HTMLElement)) {
throw new Error('No `parent` element to render on was provided.');
throw new Error("No `parent` element to render on was provided.");
}
this.rawChartArgs = options;
this.title = options.title || '';
this.type = options.type || '';
this.title = options.title || "";
this.type = options.type || "";
this.realData = this.prepareData(options.data);
this.data = this.prepareFirstData(this.realData);
@ -35,15 +52,17 @@ export default class BaseChart {
showTooltip: 1, // calculate
showLegend: 1, // calculate
isNavigable: options.isNavigable || 0,
animate: (typeof options.animate !== 'undefined') ? options.animate : 1,
truncateLegends: options.truncateLegends || 1
animate: typeof options.animate !== "undefined" ? options.animate : 1,
truncateLegends: options.truncateLegends || 1,
};
this.measures = JSON.parse(JSON.stringify(BASE_MEASURES));
let m = this.measures;
this.setMeasures(options);
if(!this.title.length) { m.titleHeight = 0; }
if(!this.config.showLegend) m.legendHeight = 0;
if (!this.title.length) {
m.titleHeight = 0;
}
if (!this.config.showLegend) m.legendHeight = 0;
this.argHeight = options.height || m.baseHeight;
this.state = {};
@ -51,7 +70,7 @@ export default class BaseChart {
this.initTimeout = INIT_CHART_UPDATE_TIMEOUT;
if(this.config.isNavigable) {
if (this.config.isNavigable) {
this.overlays = [];
}
@ -71,7 +90,7 @@ export default class BaseChart {
colors = (colors || []).concat(DEFAULT_COLORS[type]);
colors.forEach((string) => {
const color = getColor(string);
if(!isValidColor(color)) {
if (!isValidColor(color)) {
console.warn('"' + string + '" is not a valid color.');
} else {
validColors.push(color);
@ -96,14 +115,14 @@ export default class BaseChart {
this.resizeObserver = new ResizeObserver(this.boundDrawFn);
this.resizeObserver.observe(this.parent);
}
window.addEventListener('resize', this.boundDrawFn);
window.addEventListener('orientationchange', this.boundDrawFn);
window.addEventListener("resize", this.boundDrawFn);
window.addEventListener("orientationchange", this.boundDrawFn);
}
destroy() {
if (this.resizeObserver) this.resizeObserver.disconnect();
window.removeEventListener('resize', this.boundDrawFn);
window.removeEventListener('orientationchange', this.boundDrawFn);
window.removeEventListener("resize", this.boundDrawFn);
window.removeEventListener("orientationchange", this.boundDrawFn);
}
// Has to be called manually
@ -117,31 +136,31 @@ export default class BaseChart {
makeContainer() {
// Chart needs a dedicated parent element
this.parent.innerHTML = '';
this.parent.innerHTML = "";
let args = {
inside: this.parent,
className: 'chart-container'
className: "chart-container",
};
if(this.independentWidth) {
args.styles = { width: this.independentWidth + 'px' };
if (this.independentWidth) {
args.styles = { width: this.independentWidth + "px" };
}
this.container = $.create('div', args);
this.container = $.create("div", args);
}
makeTooltip() {
this.tip = new SvgTip({
parent: this.container,
colors: this.colors
colors: this.colors,
});
this.bindTooltip();
}
bindTooltip() {}
draw(onlyWidthChange=false, init=false) {
draw(onlyWidthChange = false, init = false) {
if (onlyWidthChange && isHidden(this.parent)) {
// Don't update anything if the chart is hidden
return;
@ -152,13 +171,15 @@ export default class BaseChart {
this.makeChartArea();
this.setupComponents();
this.components.forEach(c => c.setup(this.drawArea));
this.components.forEach((c) => c.setup(this.drawArea));
// this.components.forEach(c => c.make());
this.render(this.components, false);
if(init) {
if (init) {
this.data = this.realData;
setTimeout(() => {this.update(this.data);}, this.initTimeout);
setTimeout(() => {
this.update(this.data);
}, this.initTimeout);
}
this.renderLegend();
@ -174,50 +195,54 @@ export default class BaseChart {
}
makeChartArea() {
if(this.svg) {
if (this.svg) {
this.container.removeChild(this.svg);
}
let m = this.measures;
this.svg = makeSVGContainer(
this.container,
'frappe-chart chart',
"frappe-chart chart",
this.baseWidth,
this.baseHeight
);
this.svgDefs = makeSVGDefs(this.svg);
if(this.title.length) {
if (this.title.length) {
this.titleEL = makeText(
'title',
"title",
m.margins.left,
m.margins.top,
this.title,
{
fontSize: m.titleFontSize,
fill: '#666666',
dy: m.titleFontSize
fill: "#666666",
dy: m.titleFontSize,
}
);
}
let top = getTopOffset(m);
this.drawArea = makeSVGGroup(
this.type + '-chart chart-draw-area',
this.type + "-chart chart-draw-area",
`translate(${getLeftOffset(m)}, ${top})`
);
if(this.config.showLegend) {
if (this.config.showLegend) {
top += this.height + m.paddings.bottom;
this.legendArea = makeSVGGroup(
'chart-legend',
"chart-legend",
`translate(${getLeftOffset(m)}, ${top})`
);
}
if(this.title.length) { this.svg.appendChild(this.titleEL); }
if (this.title.length) {
this.svg.appendChild(this.titleEL);
}
this.svg.appendChild(this.drawArea);
if(this.config.showLegend) { this.svg.appendChild(this.legendArea); }
if (this.config.showLegend) {
this.svg.appendChild(this.legendArea);
}
this.updateTipOffset(getLeftOffset(m), getTopOffset(m));
}
@ -225,15 +250,17 @@ export default class BaseChart {
updateTipOffset(x, y) {
this.tip.offset = {
x: x,
y: y
y: y,
};
}
setupComponents() { this.components = new Map(); }
setupComponents() {
this.components = new Map();
}
update(data) {
if(!data) {
console.error('No data to update.');
if (!data) {
console.error("No data to update.");
}
this.data = this.prepareData(data);
this.calc(); // builds state
@ -241,31 +268,31 @@ export default class BaseChart {
this.renderLegend();
}
render(components=this.components, animate=true) {
if(this.config.isNavigable) {
render(components = this.components, animate = true) {
if (this.config.isNavigable) {
// Remove all existing overlays
this.overlays.map(o => o.parentNode.removeChild(o));
this.overlays.map((o) => o.parentNode.removeChild(o));
// ref.parentNode.insertBefore(element, ref);
}
let elementsToAnimate = [];
// Can decouple to this.refreshComponents() first to save animation timeout
components.forEach(c => {
components.forEach((c) => {
elementsToAnimate = elementsToAnimate.concat(c.update(animate));
});
if(elementsToAnimate.length > 0) {
if (elementsToAnimate.length > 0) {
runSMILAnimation(this.container, this.svg, elementsToAnimate);
setTimeout(() => {
components.forEach(c => c.make());
components.forEach((c) => c.make());
this.updateNav();
}, CHART_POST_ANIMATE_TIMEOUT);
} else {
components.forEach(c => c.make());
components.forEach((c) => c.make());
this.updateNav();
}
}
updateNav() {
if(this.config.isNavigable) {
if (this.config.isNavigable) {
this.makeOverlay();
this.bindUnits();
}
@ -273,24 +300,24 @@ export default class BaseChart {
renderLegend() {}
setupNavigation(init=false) {
if(!this.config.isNavigable) return;
setupNavigation(init = false) {
if (!this.config.isNavigable) return;
if(init) {
if (init) {
this.bindOverlay();
this.keyActions = {
'13': this.onEnterKey.bind(this),
'37': this.onLeftArrow.bind(this),
'38': this.onUpArrow.bind(this),
'39': this.onRightArrow.bind(this),
'40': this.onDownArrow.bind(this),
13: this.onEnterKey.bind(this),
37: this.onLeftArrow.bind(this),
38: this.onUpArrow.bind(this),
39: this.onRightArrow.bind(this),
40: this.onDownArrow.bind(this),
};
document.addEventListener('keydown', (e) => {
if(isElementInViewport(this.container)) {
document.addEventListener("keydown", (e) => {
if (isElementInViewport(this.container)) {
e = e || window.event;
if(this.keyActions[e.keyCode]) {
if (this.keyActions[e.keyCode]) {
this.keyActions[e.keyCode]();
}
}
@ -319,6 +346,6 @@ export default class BaseChart {
export() {
let chartSvg = prepareForExport(this.svg);
downloadFile(this.title || 'Chart', [chartSvg]);
downloadFile(this.title || "Chart", [chartSvg]);
}
}