jingrow/charts
1
0
Fork 0
Code Pull Requests Activity

Remove minimum height for zero-values in bar chart

Browse Source 
Fixes #201.

This is really a UX issue.

Previously, if any datapoint was a zero-value, it would still be visible on the chart, making it seem it has non-zero data.

P.S. I wasn't able to run the contribution steps locally, so I have no idea how to rebuild the distribution(s). That might need a separate commit/PR.
This commit is contained in:
Rohan 2018-12-19 15:37:57 +05:30 committed by GitHub
parent 81cddd45a3
commit 87b68e9d7e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/js/utils/constants.js
View File

@ -68,7 +68,7 @@ export const AXIS_DATASET_CHART_TYPES = ['line', 'bar'];
export const AXIS_LEGEND_BAR_SIZE = 100;
export const BAR_CHART_SPACE_RATIO = 0.5;
export const MIN_BAR_PERCENT_HEIGHT = 0.01;
export const MIN_BAR_PERCENT_HEIGHT = 0.00;
export const LINE_CHART_DOT_SIZE = 4;
export const DOT_OVERLAY_SIZE_INCR = 4;