jingrow/charts
1
0
Fork 0
Code Pull Requests Activity

Merge pull request #238 from frappe/fix-event-listener

Browse Source 
fix: destroying event listener on window
This commit is contained in:
Shivam Mishra 2019-08-11 22:17:34 +05:30 committed by GitHub
commit 317136eec4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
docs/index.html
View File

@ -261,7 +261,7 @@ redirect_to: "https://frappe.io/charts"
chart.export(); chart.export();
// Unbind window-resize events // Unbind window-resize events
chart.unbindWindowEvents(); chart.destroy();
</code></pre> </code></pre>
</section> </section>

18
src/js/charts/BaseChart.js
View File

@ -7,8 +7,6 @@ import { getColor, isValidColor } from '../utils/colors';
import { runSMILAnimation } from '../utils/animation'; import { runSMILAnimation } from '../utils/animation';
import { downloadFile, prepareForExport } from '../utils/export'; import { downloadFile, prepareForExport } from '../utils/export';
let BOUND_DRAW_FN;
export default class BaseChart { export default class BaseChart {
constructor(parent, options) { constructor(parent, options) {
@ -90,18 +88,14 @@ export default class BaseChart {
this.height = height - getExtraHeight(this.measures); this.height = height - getExtraHeight(this.measures);
// Bind window events // Bind window events
BOUND_DRAW_FN = this.boundDrawFn.bind(this); this.boundDrawFn = () => this.draw(true);
window.addEventListener('resize', BOUND_DRAW_FN); window.addEventListener('resize', this.boundDrawFn);
window.addEventListener('orientationchange', this.boundDrawFn.bind(this)); window.addEventListener('orientationchange', this.boundDrawFn);
} }
boundDrawFn() { destroy() {
this.draw(true); window.removeEventListener('resize', this.boundDrawFn);
} window.removeEventListener('orientationchange', this.boundDrawFn);
unbindWindowEvents() {
window.removeEventListener('resize', BOUND_DRAW_FN);
window.removeEventListener('orientationchange', this.boundDrawFn.bind(this));
} }
// Has to be called manually // Has to be called manually