jingrow/charts
1
0
Fork 0
Code Pull Requests Activity

Merge pull request #164 from t47io/fix-bound-event-listener

Browse Source 
Fix bound listener
This commit is contained in:
Prateeksha Singh 2018-04-24 00:52:35 +05:30 committed by GitHub
commit 08d0b93135
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
9 changed files with 21 additions and 31 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
dist/frappe-charts.esm.js vendored
View File

@ -1312,8 +1312,6 @@ function prepareForExport(svg) {
return container.innerHTML; return container.innerHTML;
} }
let BOUND_DRAW_FN;
class BaseChart { class BaseChart {
constructor(parent, options) { constructor(parent, options) {
@ -1394,18 +1392,15 @@ class BaseChart {
this.height = height - getExtraHeight(this.measures); this.height = height - getExtraHeight(this.measures);
// Bind window events // Bind window events
BOUND_DRAW_FN = this.boundDrawFn.bind(this); this.boundDrawFn = () => this.draw(true);
window.addEventListener('resize', BOUND_DRAW_FN); window.addEventListener('resize', this.boundDrawFn);
window.addEventListener('orientationchange', this.boundDrawFn.bind(this)); window.addEventListener('orientationchange', this.boundDrawFn);
} }
boundDrawFn() { destroy() {
this.draw(true); // Unbind window events
} window.removeEventListener('resize', this.boundDrawFn);
window.removeEventListener('orientationchange', this.boundDrawFn);
unbindWindowEvents() {
window.removeEventListener('resize', BOUND_DRAW_FN);
window.removeEventListener('orientationchange', this.boundDrawFn.bind(this));
} }
// Has to be called manually // Has to be called manually

2
dist/frappe-charts.min.cjs.js vendored
View File

File diff suppressed because one or more lines are too long

2
dist/frappe-charts.min.cjs.js.map vendored
View File

File diff suppressed because one or more lines are too long

2
dist/frappe-charts.min.esm.js vendored
View File

File diff suppressed because one or more lines are too long

2
dist/frappe-charts.min.esm.js.map vendored
View File

File diff suppressed because one or more lines are too long

2
docs/assets/js/frappe-charts.min.js vendored
View File

File diff suppressed because one or more lines are too long

2
docs/assets/js/frappe-charts.min.js.map
View File

File diff suppressed because one or more lines are too long

2
docs/index.html
View File

@ -301,7 +301,7 @@
chart.export(); chart.export();
// Unbind window-resize events // Unbind window-resize events
chart.unbindWindowEvents(); chart.destroy();
</code></pre> </code></pre>
</div> </div>

19
src/js/charts/BaseChart.js
View File

@ -7,8 +7,6 @@ import { getColor, isValidColor } from '../utils/colors';
import { runSMILAnimation } from '../utils/animation'; import { runSMILAnimation } from '../utils/animation';
import { downloadFile, prepareForExport } from '../utils/export'; import { downloadFile, prepareForExport } from '../utils/export';
let BOUND_DRAW_FN;
export default class BaseChart { export default class BaseChart {
constructor(parent, options) { constructor(parent, options) {
@ -89,18 +87,15 @@ export default class BaseChart {
this.height = height - getExtraHeight(this.measures); this.height = height - getExtraHeight(this.measures);
// Bind window events // Bind window events
BOUND_DRAW_FN = this.boundDrawFn.bind(this); this.boundDrawFn = () => this.draw(true);
window.addEventListener('resize', BOUND_DRAW_FN); window.addEventListener('resize', this.boundDrawFn);
window.addEventListener('orientationchange', this.boundDrawFn.bind(this)); window.addEventListener('orientationchange', this.boundDrawFn);
} }
boundDrawFn() { destroy() {
this.draw(true); // Unbind window events
} window.removeEventListener('resize', this.boundDrawFn);
window.removeEventListener('orientationchange', this.boundDrawFn);
unbindWindowEvents() {
window.removeEventListener('resize', BOUND_DRAW_FN);
window.removeEventListener('orientationchange', this.boundDrawFn.bind(this));
} }
// Has to be called manually // Has to be called manually